Fix crash without arguments #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was quick :) Thanks. Should we add a simple test for this? Since the reproducer is almost trivial this should be straight forwardish(?) It seems like I have missed one of the things related to key4hep/EDM4hep#188 which causes the nightlies based CI to fail. |
|
Yeah I can add a test. This shouldn't be an EDM4hep issue because it's the same version that has been built for the nightlies (which built fine today) |
|
Actually it was: #111 |
|
do you build / run the tests in the nightlies? Because here the problem is in there |
tmadlener
reviewed
Jun 15, 2023
tmadlener
approved these changes
Jun 15, 2023
tmadlener
force-pushed
the
fix-no-arguments
branch
from
7d086a8 to
b7a5df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
and now exits unsuccessfully