-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in edm4hep.yaml for consistent naming #188
Conversation
I'm not aware if this is standard or not but a change like this affects other repos, in this case it would be |
Yes, this definitely affects other repos as well, plus it also requires schema evolution support from podio. So for now, we will just leave this open, and then go for a concerted effort with all other repositories affected. |
As discussed during todays meeting. This does in fact not (yet) need schema evolution since the branch names are index based in all the files that have been written up until now. This will need some changes in the converters probably, but they should be fairly straight forward. |
To avoid too many problems in dependencies, we need to tag EDM4hep pretty much immediately after this has been merged. |
If we increment the patch version to 99 (and set to correct version for the tag), we should be able to compare against the last tagged version even with the master branch? |
Yeah that should work, but a new tag would be nice in any case, since we don't have a tag yet with the |
Changed the name of one VectorMember of edm4hep::track from subDetectorHitNumbers to subdetectorHitNumbers to be consistent with other spellings of the word subdetector in the yaml and in lcio.
In a local build of the key4hep stack this breaks a few more things than just the converter. I will prepare PRs to fix those as well. |
The PRs in CEPCSW and k4LCIOReader should make this work smoothly once they are merged. |
Why the |
I think they are necessary in some of our CI workflows for a cleaner test environment (or at least one that has the "underlying" environment late enough in order to not pick it up). I must confess, I overlooked these when merging, but I don't think they harm us either. |
BEGINRELEASENOTES
ENDRELEASENOTES