Rename SubDetectorHitNumbers to SubdetectorHitNumbers #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seem to be a few more places where this needs to be corrected: https://github.com/key4hep/k4MarlinWrapper/actions/runs/5280968864/jobs/9553869438?pr=115#step:5:91 |
|
I am not entirely sure why the tests are failing for the nightlies. I can't really reproduce them locally |
|
I couldn't reproduce that issue but this is needed anyway for so I'll merge and check if the tests need to be fixed or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Needed after key4hep/EDM4hep#188, ugly...