Implement esapi crate and conf edition 2018 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of changes in here: * Implement the ESAPI wrapper crate * Set up a simple connection context to the TPM * Remove extern crate calls for edition 2018 * Comment out unused tpm calls in response handlers Use of this change will require setting up the tpm2-tss. I will document this in the readme and / or wiki
puiterwijk
reviewed
Oct 1, 2020
archive/main.rs
Outdated
| @@ -0,0 +1,552 @@ | |||
| #[macro_use] | |||
There was a problem hiding this comment.
I would suggest not putting in the archive/ files here.
If we need them, they'll be in the Git history forever.
There was a problem hiding this comment.
I agree. I had the same thought and considerated both. I will make another commit and remove archive/
|
CI failure is rustfmt results. |
added 2 commits
October 1, 2020 15:16
|
would be nice to merge this, so we can start to lay down the main tpm code next week is there anything else anyone would like changed? |
ashcrow
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of changes in here:
Use of this change will require setting up the tpm2-tss. I will
document this in the readme and / or wiki