Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Install tpm-tss2 dependencies #112

Merged
merged 1 commit into from
Oct 5, 2020
Merged

ci: Install tpm-tss2 dependencies #112

merged 1 commit into from
Oct 5, 2020

Conversation

ashcrow
Copy link
Contributor

@ashcrow ashcrow commented Oct 1, 2020

Resolves: #108

@ashcrow ashcrow requested a review from lukehinds October 1, 2020 15:50
@ashcrow
ci: Install tpm-tss2 dependencies
7101ce4 
Resolves: keylime#108

Signed-off-by: Steve Milner <[email protected]>
@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 1, 2020

Using https://packages.ubuntu.com/search?keywords=tss for finding the right package

lukehinds
lukehinds approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should be able to land #107 now if all are happy with the state of the PR

@ashcrow ashcrow changed the title WIP: ci: Install tpm-tss2 dependencies ci: Install tpm-tss2 dependencies Oct 1, 2020
@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 1, 2020

The failure CI hit is unrelated to this bug and will be worked out in another PR (possibly #107)

@ashcrow ashcrow requested review from font and lkatalin October 2, 2020 17:52
@lukehinds lukehinds merged commit 0235d0c into keylime:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

@font font Awaiting requested review from font

@lkatalin lkatalin Awaiting requested review from lkatalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG tpm-tss required in CI
2 participants
@ashcrow @lukehinds