-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override config location with environment variable #161
Conversation
dd2ae45
to
2db5684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a great improvement; thank you for working on this!
2db5684
to
9bc6244
Compare
Hrm the failure looks like code I didn't touch ...
I'm willing to look at it deeper if required though. |
Looks like the failure is related to the revocation scripts (not sure why clippy didn't catch this on the earlier PR). I'm making a fix for this and then you can rebase on that. The changes LGTM! |
I went down a bit of a rabbit hole, but #162 should help once it is merged. |
9bc6244
to
2be3cb9
Compare
Rebased on #162 |
Woo! All green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great : )
KEYLIME_CONFIG can be set to override the default config file location. Signed-off-by: Steve Milner <[email protected]>
2be3cb9
to
6d69d3b
Compare
Rebased |
Merging per discussion. |
KEYLIME_CONFIG
can be set to override the default config file location.Note:
I think we should eventually rework the configuration system so that we load the configuration once and then reload when we receive the proper signal. My reasoning is that the current set up means that if the file changes while the agent is running then the result could be old and new variables in use based on when they have been read. I've started to make structs for the keylime config. If folks agree I'll slowly but surely chip away at that no matter if this merges or not 😄