Update error handling for revocation scripts #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lily Sturmann <[email protected]>
ashcrow
reviewed
Mar 2, 2021
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "goodbye" : "there" | |||
ashcrow
approved these changes
Mar 2, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clippy error on #161 indicated better ways of handling errors on revocation scripts. I've made updates here that should make the code more readable and make clippy happy. Also, added a unit test for an error case in the revocation scripts.
Tl;dr the error handling now largely takes place in
error.rsand in therun_revocation_actions()function, which just adds some context (of which script was running) to anError::Executionto create anError::Script. This makes therun_action()function much shorter and gets rid of some redundant boilerplate code.