fix CRDExists check #10352
Closed
fix CRDExists check #10352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishb-solo
pushed a commit
to ashishb-solo/k8sgateway
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current method of checking CRD existence fails with
error checking if TCPRoute CRD exists: the server could not find the requested resourcewhen I have v1 CRDs installed.Fixes #10351
Code changes
errors.IsNotFoundand returnfalse, nil. The check didn't error, but we didn't find it.Testing steps
TestConfigureHTTPRouteBackingDestinationsWithServiceAndWithoutTCPRoutestyle test, but I don't know how the APIServer will behave... we need it to think it never saw that group version?