project/gateway2: Adds errors.IsNotFound check to CRDExists() #10353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Heilbron <[email protected]> Co-authored-by: Ian Rudie <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
|
Closing in favor of #10352 |
|
Reopening since #10352 was closed. |
danehans
force-pushed
the
issue_10351
branch
from
0ca3303 to
625423f
Compare
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
danehans
force-pushed
the
issue_10351
branch
from
625423f to
ceb6743
Compare
stevenctl
added a commit
to stevenctl/gloo
that referenced
this pull request
Nov 15, 2024
fix CRDExists check
|
/hold since solo-io#10353 fixes this issue in the gloo repo. |
|
Closing due to force push from b545ea8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
CRDExists()error check cases to includeapierrors.IsNotFound(err).Fixes #10351