Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule tests should dump the logs on failure #74

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

jmazzitelli
Copy link
Contributor

fixes kiali/kiali#2984

do not squash merge this - the one commit moves to molecule 3 (a prerequisite). The next commit implements the fix.

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the details but it seems fine and if you get more logs on failure that's a good thing.

@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Jul 13, 2020

Ignore the error - there is a regression that was introduced in operator-courier 2.1.8 that was just released which is causing the failure here. See operator-framework/operator-courier#188

@jmazzitelli jmazzitelli merged commit c856236 into kiali:master Jul 13, 2020
@jmazzitelli jmazzitelli deleted the molecule-get-logs-on-failure branch July 13, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

molecule tests should grab server logs on failures
2 participants