Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression?] operator-courier 2.1.8 falsely(?) fails --ui_validate_io check #188

Closed
leifmadsen opened this issue Jul 13, 2020 · 6 comments · Fixed by #189
Closed

[regression?] operator-courier 2.1.8 falsely(?) fails --ui_validate_io check #188

leifmadsen opened this issue Jul 13, 2020 · 6 comments · Fixed by #189

Comments

@leifmadsen
Copy link

My CI started failing today on the operator-courier verify --ui_validate_io check for my Ansible Operators (probably not related to Ansible).

Version 2.1.7 does not result in a failure. When running 2.1.8 I get the following error on my checks:

operator-courier verify --ui_validate_io deploy/olm-catalog/service-telemetry-operator/
ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [0.1.1/service-telemetry-operator.v0.1.1.clusterserviceversion.yaml]
ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.0.0/service-telemetry-operator.v1.0.0.clusterserviceversion.yaml]
ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.0.1/service-telemetry-operator.v1.0.1.clusterserviceversion.yaml]
ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.0.2/service-telemetry-operator.v1.0.2.clusterserviceversion.yaml]
ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.0.3/service-telemetry-operator.v1.0.3.clusterserviceversion.yaml]
Resulting bundle is invalid, input yaml is improperly defined.

CSVs are available here: https://github.com/infrawatch/service-telemetry-operator/tree/master/deploy/olm-catalog/service-telemetry-operator/1.0.2 (version 1.0.2 as an example).

Looking at what the error is telling me, it seems like everything is fine?

CSV --> spec --> CRD --> owned --> version == https://github.com/infrawatch/service-telemetry-operator/blob/master/deploy/olm-catalog/service-telemetry-operator/1.0.2/service-telemetry-operator.v1.0.2.clusterserviceversion.yaml#L93

CRD --> spec --> versions == https://github.com/infrawatch/service-telemetry-operator/blob/master/deploy/olm-catalog/service-telemetry-operator/1.0.2/infra.watch_servicetelemetrys_crd.yaml#L16-L19
@leifmadsen leifmadsen mentioned this issue Jul 13, 2020
Closed
@jmazzitelli
Copy link

jmazzitelli commented Jul 13, 2020 •
edited
Loading

I'm seeing the same - I haven't changed the community metadata for my operator in a while - and just today when an unrelated PR got submitted and travis ran the CI tests, I get this:

ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.15.1/kiali.v1.15.1.clusterserviceversion.yaml]

See Kiali community metadata: https://github.com/operator-framework/community-operators/tree/master/community-operators/kiali/1.15.1

@tiraboschi
Copy link
Contributor

We are also facing this on CI on https://github.com/kubevirt/hyperconverged-cluster-operator

@tiraboschi tiraboschi mentioned this issue Jul 13, 2020
Merged
@jmazzitelli jmazzitelli mentioned this issue Jul 13, 2020
Merged
@leifmadsen
Copy link
Author

FYI the workaround is to pin operator-courier==2.1.7

jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Jul 13, 2020
@jmazzitelli
need to pin to courier 2.1.7 due to operator-framework/operator-couri…
1a7e4f5 
…er#188
@jmazzitelli jmazzitelli mentioned this issue Jul 13, 2020
Merged
tiraboschi added a commit to tiraboschi/operator-courier that referenced this issue Jul 13, 2020
@tiraboschi
Correctly validate crd.spec.versions
3cf3b88 
crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]

Fixes: operator-framework#188
@tiraboschi tiraboschi mentioned this issue Jul 13, 2020
Merged
@tiraboschi
Copy link
Contributor

Yes, I think this is definitively a regression introduced with #165
It affects all the bundles that include a CRD with spec.versions.

#189 should fix it.

tiraboschi added a commit to tiraboschi/operator-courier that referenced this issue Jul 13, 2020
@tiraboschi
Correctly validate crd.spec.versions
efdd5d2 
crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]

Fixes: operator-framework#188
nunnatsa added a commit to nunnatsa/hyperconverged-cluster-operator that referenced this issue Jul 14, 2020
@nunnatsa
workarounf operator-courier issue kubevirt#188 (operator-framework/op…
6f9e593 
…erator-courier#188)

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
kubevirt-bot pushed a commit to kubevirt/hyperconverged-cluster-operator that referenced this issue Jul 14, 2020
@nunnatsa
Fix BZ 1856447 (#700)
233dc61 
* Fix BZ 1856447

    Fix error that if all the components are running, but not all of them are with the latest version, HCO reports "ready" but it should not.

    This fix make sure that HCO only set ready for successful upgrade, when all the operators are with the right version

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

* workarounf operator-courier issue #188 (operator-framework/operator-courier#188)

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@Kaitou786
Copy link

I believe the latest quay.io/operator-framework/operator-testing:latest has been updated with this version of operator-courier. We are facing the same issue in our CI: https://github.com/kiegroup/kogito-cloud-operator

This was referenced Jul 14, 2020
Merged
Merged
tiraboschi added a commit to tiraboschi/operator-courier that referenced this issue Jul 15, 2020
@tiraboschi
Correctly validate crd.spec.versions
3243d39 
crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix all the validations on spec.versions and add
additional validations.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]

Fixes: operator-framework#188
tiraboschi added a commit to tiraboschi/operator-courier that referenced this issue Jul 15, 2020
@tiraboschi
Correctly validate crd.spec.versions
6183101 
crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix all the validations on spec.versions and add
additional validations.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]
Fixes: operator-framework#188
@givanov givanov mentioned this issue Jul 15, 2020
Merged
26 tasks
@J0zi
Copy link

J0zi commented Jul 20, 2020

all of the sudden, not only 2.1.8, but also older versions (2.1.7 and 2.1.6) are failing on the stuff which was green in the past.

@J0zi J0zi mentioned this issue Jul 20, 2020
Merged
26 tasks
orenc1 added a commit to kubevirt/hyperconverged-cluster-operator that referenced this issue Jul 21, 2020
@orenc1
remove pinning for operator-courier
aefd116 
operator-framework/operator-courier#188 is resolved.

Signed-off-by: orenc1 <[email protected]>
kubevirt-bot pushed a commit to kubevirt/hyperconverged-cluster-operator that referenced this issue Jul 21, 2020
@github-actions @web-flow @orenc1
Bump CDI to v1.20.1 (#709)
553205f 
* Bump CDI to v1.20.1

Signed-off-by: hco_bump_bot <[email protected]>

* build-manifests.sh

Signed-off-by: orenc1 <[email protected]>

* remove pinning for operator-courier
operator-framework/operator-courier#188 is resolved.

Signed-off-by: orenc1 <[email protected]>

Co-authored-by: GitHub <[email protected]>
Co-authored-by: orenc1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly validate crd.spec.versions tiraboschi/operator-courier
5 participants
@leifmadsen @jmazzitelli @tiraboschi @Kaitou786 @J0zi