Skip to content

Commit

Permalink
Use the correct settings for compression combinations test (microsoft…
Browse files Browse the repository at this point in the history
…#22147)

A change in `compatUtils.ts` means that we aren't using the defaults
from the ContainerRuntime. Thus, this test isn't actually testing what
we want.

This wasn't causing any failures or flaky behavior, but it needed to be
corrected.
  • Loading branch information
kian-thompson authored Aug 8, 2024
1 parent ba440c1 commit ffe8248
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions packages/test/test-end-to-end-tests/src/test/compression.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,15 @@ const compressionSuite = (getProvider) => {
this.skip();
}
await setupContainers({
compressionOptions: option.compressionAndChunking.compression
? {
minimumBatchSizeInBytes: 10,
compressionAlgorithm: CompressionAlgorithms.lz4,
}
: undefined,
chunkSizeInBytes: option.compressionAndChunking.chunking ? 100 : undefined,
compressionOptions: {
minimumBatchSizeInBytes: option.compressionAndChunking.compression
? 10
: Number.POSITIVE_INFINITY,
compressionAlgorithm: CompressionAlgorithms.lz4,
},
chunkSizeInBytes: option.compressionAndChunking.chunking
? 100
: Number.POSITIVE_INFINITY,
enableGroupedBatching: option.grouping,
});
const values = [
Expand Down

0 comments on commit ffe8248

Please sign in to comment.