Remove text bounds estimation #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on startup for AWT klighd: added properties to set on KTexts for setting individual line widths and heights for texts
non-platform case. Allow AWT size estimation to estimate multiline texts correctly and set text estimation properties on the text.
default monospace font (overpass mono)
|
@sailingKieler Could you please have a look at the changes here made outside of the .lsp plugin? I added two font files to be registered in standalone applications, adapted the text size estimation to allow getting per-line estimations for multiline text, and modified the default font to use Overpass in the case that we are not in an Eclipse context. |
|
Left to do: add the font license as a seperate .txt file next to the fonts as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the text bounds estimation overhead in the lsp Bundle by estimating the texts with the same (open) font named Overpass on both server and client, thus making the server able to approximate the client text sizes more accurate.
To be merged together with the accompanying PR with the required client changes in klighd-vscode (#20)
Also touches the standalone plugin to register the Overpass and Overpass Mono fonts with AWT when starting some standalone application such as a CLI tool or a language server.