Remove text bounds estimation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klighd-cli: add and package default font to be used in diagrams. klighd-vscode: add and package default font to be used in diagrams, does not fully work here yet though (access denied error on GET request of the font)
Now it uses @font-face style with direct base-64 encoding of the fonts and does not require any external file to be installed or referenced via the network anywhere for the cost of bigger SVGs when exporting. Also added a new monospace font to be used as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the text bounds estimation overhead by estimating the texts with the same (open) font named Overpass on both server and client, thus making the server able to approximate the client text sizes more accurate.
To be merged together with the accompanying PR with the required server changes in KLighD (#101)