Update calico to 3.16.4 #1113
Update calico to 3.16.4 #1113
Conversation
Signed-off-by: Imran Pochi <[email protected]>
This commit adds calico-kube-controllers ServiceAccount, ClusterRoleBinding and ClusterRole to the correct location `cluster-role-binding.yaml`, `cluster-role.yaml` and `service-account.yaml`. Signed-off-by: Imran Pochi <[email protected]>
This commit updates Calico to the version 3.16.4. Renames the file `daemonset.yaml` to correctly reflect the resource it contains i.e `calico-node.yaml` Renames the file `deployment.yaml` to correctly reflect the resource it contains i.e `calico-kube-controllers.yaml` Updates the calico config. Signed-off-by: Imran Pochi <[email protected]>
ipochi
force-pushed
the
imran/update-calico-to-3.16.4
branch
from
2472d1f to
b94e31f
Compare
| @@ -0,0 +1,50 @@ | |||
| # See https://github.com/projectcalico/kube-controllers | |||
There was a problem hiding this comment.
I mean moving from deployment.yaml to this file?
There was a problem hiding this comment.
No I mean , this makes the file naming correct to the resource it holds.
There was a problem hiding this comment.
the file was named deployment.yaml, it contain the deployment resource. I renamed it reflect better.
Similar with daemonset.yaml
deployment.yaml - calico-kube-controllers.yaml
daemonset.yaml - calico-node.yaml
| @@ -3,7 +3,7 @@ kind: CustomResourceDefinition | |||
| metadata: | |||
There was a problem hiding this comment.
nit:
- calico: update calico CRDS
+ calico: update calico CRDs| @@ -1,3 +1,4 @@ | |||
| --- | |||
There was a problem hiding this comment.
Honestly, the best would be to have everything in calico.yaml, as from wget https://docs.projectcalico.org/v3.16.4/manifests/calico.yaml
There was a problem hiding this comment.
IMO, we should look into integrating Tigera Operator in our helm chart.
There was a problem hiding this comment.
Hm, perhaps this is the way to go.
Created #1125 for tracking.
This PR updates calico to 3.16.4