Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show actual values in info messages #1453

Closed
wants to merge 64 commits into from
Closed

Show actual values in info messages #1453

wants to merge 64 commits into from

Conversation

dbrnz
Copy link
Contributor

@dbrnz dbrnz commented Nov 9, 2018

No description provided.

@inclement
Added python3 and hostpython3 files
dc8619b
@inclement
Added hostpython3 recipe
008b41d
@inclement
Got python3 recipe to the point of configure working
901a153
@inclement
Progressed the python3 recipe enough that python3 can be built
8f8a050
@inclement
Added a temporary hardcoded APP_PLATFORM setting
a99478d
@inclement
Made other recipe types build properly when using python3
43ce635 
This is just a preliminary, hacky implementation.
@inclement
Made bootstrap collation work with python3 recipe
3a09e10
@inclement
Fixed bootstrap code to correctly load and run a python3 bundle
4a78c13
@inclement
Did initial implementation of an ndk-api build target option
1d22bdd
@inclement
Made bootstraps check the ndk api against the requested minsdk
9491855
@inclement
Fixed APP_PLATFORM setting
9423cc8
@inclement
Moved from bpo-30386 branch to python 3.7.0 official distribution
545aa02
@inclement
Made all version references in python url dynamic
5a4d443
@inclement
Began moving python bundle creation to the Python recipe
24a57be
@inclement
Moved python3crystax python bundling to the recipe class
0e0036a
@inclement
Moved python2 python bundle creation to python recipe
bd38265
@inclement
Applied tito's fixes for python recipes installed via pip
a0838b6
@inclement
Fixed webbrowser registration for python3
0f21372 
Following tito's patch
@inclement
Updated python3 recipe target version to 3.7.1
4a094d8
@inclement
Made __ANDROID_API__ take the same value as APP_PLATFORM
d0f0113
@inclement
Corrected NDK platform finding to use ndk_api instead of android_api
b58febc
@inclement
Added include_root and link_root to python3 and python3crystax
d419f62
@inclement
Introduced some preliminary stdlib pruning during zip packaging
1ebdcee
@inclement
Refactored out function for getting valid filens from a folder
d786718
@inclement
Made site-packages copying exclude some files/folders
4964ec2 
(in a temporary hacky way)
@inclement
Deleted some old commented out code
ec7ecac
@inclement
Made create_python_bundle return the site-packages dir
a80fc6f
@inclement
Restructured dist_info.json creation
d2435d6
@inclement
Removed hardcoded python version from sdl2 recipe
07ae059
@inclement
Removed hardcoded api 21 in python3 recipe
3932fe2
@AndreMiras
Copy link
Member

I agree this is a good improvement, but I worry this could conflict with the soon to be merged #1412
So I prefer to put on hold before merging if you don't mind.

@dbrnz
Copy link
Contributor Author

dbrnz commented Nov 9, 2018

That's fine -- I'll update the patch after #1412 goes in.

AndreMiras and others added 10 commits November 9, 2018 16:01
@AndreMiras
Merge pull request kivy#1452 from dbrnz/wrong_cpp_env_flags
2d98daa 
C++ recipe didn't set all instances of `ctx.ndk_dir` in format string
@tshirtman
allow installing/using p4a in a virtualenv
8f1c25f
@inclement
Added path to hostpython in python3 build env
f150014
@inclement
Updated python3 testapp ndk-api to 21
82ad9e5
@goffi-contrib
[protobuf_cpp] Updated to Protobuf 3.5.1 + fixed protoc issue
856a02a 
Protobuf has been updated to 3.5.1, it's not the last version (3.6.1)
because last version cause trouble during compilation and needs more
work.

This patch also fixes the issue with hardcoded local path for protoc which
could not work. Protobuf needs a version of "protoc" (its compiler, used
to produce .py file from .proto files) compiled for the host platform.
Official binaries for protoc are available, the recipe will download the
one suitable for host and use it.
If the platform is not supported, building may still work if the right "protoc"
is available in search path.
@AndreMiras
Merge pull request kivy#1440 from goffi-contrib/protobuf_update
6369041 
[protobuf_cpp] Updated to Protobuf 3.5.1 + fixed protoc issue
@goffi-contrib
[cffi] Updated recipe to last cffi version (1.11.5)
78cf9e9
@inclement
Removed Python3 testapp from CI for now
b076cd9
@inclement
Merge pull request kivy#1412 from inclement/python3_recipe
146bab2 
Python 3 recipe
@AndreMiras
Merge pull request kivy#1441 from goffi-contrib/cffi_update
5382dc0 
[cffi] Updated recipe to last cffi version (1.11.5)
@AndreMiras
Copy link
Member

Hi @dbrnz #1412 just got merged so you can rebase your changes on it.

Also just wondering if we could simplify the "wording" further by replacing:

info('Found Android API target in $ANDROIDAPI: it is {}'.format(android_api))

By directly:

info('Found Android API target in $ANDROIDAPI: {}'.format(android_api))

So skipping the "it is" part in each case. And we can also probably skip the line break (if tox doesn't mind).
It's just a suggestion, but what do you think?

@dbrnz
Copy link
Contributor Author

dbrnz commented Nov 10, 2018 •
edited
Loading

Hmm, my attempt at rebasing has pulled in all of #1412's patches... I'm closing this PR and will create a new one (#1458) that has just my stuff. And yes to removing the "it is" (another similar message had "it is" so copied the wording...).

@dbrnz dbrnz closed this Nov 10, 2018
@dbrnz dbrnz deleted the improve_messages branch November 10, 2018 21:45
@dbrnz dbrnz mentioned this pull request Nov 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbrnz @AndreMiras @inclement @tshirtman @goffi-contrib @wolfgangp