Remove javascript:void. Refs #189

kiwitcms · Feb 6, 2020 · 2ab3f74 · 2ab3f74
1 parent a38f97a
commit 2ab3f74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tcms/templates/run/assign_case.html b/tcms/templates/run/assign_case.html
@@ -93,7 +93,7 @@ <h2 id="display_title">Add TestCase(s) to <a href="{% url "testruns-get" test_ru
 							<a href="{% url "testcases-get" test_case.case %}">{{ test_case.case }}</a>
 						</td>
 						<td class="js-case-summary" data-param="{{ forloop.counter }}" >
-							<a id="link_{{ forloop.counter }}" class="blind_title_link" href="javascript:void(0);">
+							<a id="link_{{ forloop.counter }}" class="blind_title_link" href="{% url "testcases-get" test_case.case %}">
 								{{ test_case.case__summary }}
 							</a>
 						</td>

diff --git a/tcms/testruns/tests/test_views.py b/tcms/testruns/tests/test_views.py
@@ -517,15 +517,17 @@ def test_show_add_cases_to_run(self):
         # Check listed case properties
         # note: the response is ordered by 'case'
         for loop_counter, case in enumerate(confirmed_cases, 1):
+            case_url = reverse('testcases-get', args=[case.pk])
             html_pieces = [
                 '<a href="{0}">{1}</a>'.format(
-                    reverse('testcases-get', args=[case.pk]),
+                    case_url,
                     case.pk),
 
                 '<td class="js-case-summary" data-param="{0}">'
                 '<a id="link_{0}" class="blind_title_link" '
-                'href="javascript:void(0);">{1}</a></td>'.format(loop_counter,
-                                                                 case.summary),
+                'href="{2}">{1}</a></td>'.format(loop_counter,
+                                                 case.summary,
+                                                 case_url),
 
                 '<td>{0}</td>'.format(case.author.username),
                 '<td>{0}</td>'.format(