-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove javascript:void links #189
Comments
Down to 15 ATM. Migration to Patternfly helps resolve these issues. Also related #241. |
Why use void(0) in JavaScript? The void operator evaluates the given expression and then returns undefined. If you have pass 0 as the unary expression operand to the void operator, JavaScript coerces 0 to "false" and returns, but void doesn't care and simply returns undefined, which means "do nothing" . Put them together and you have composed a way to programmatically "do nothing" when a link is clicked. JavaScript Void(0) is often used when, inserting an expression into a web page may produce an unwanted side-effect. |
there are no-more legacy run/ templates and the only one left is merges inside its parent. Closes kiwitcms#189 because there are no more `javascript:void` references left in the code base. Closes kiwitcms#241 because there are no more legacy buttons.
there are no-more legacy run/ templates and the only one left is merges inside its parent. Closes kiwitcms#189 because there are no more `javascript:void` references left in the code base. Closes kiwitcms#241 because there are no more legacy buttons.
As stated in:
https://stackoverflow.com/questions/1291942/what-does-javascriptvoid0-mean/1293130#1293130
this is now a very old approach and not really necessary. It needs to go.
Notes:
false
as stated in the SO answer.Send PRs for this in small groups and work on 1 template at a time.
The text was updated successfully, but these errors were encountered: