Skip to content

Commit

Permalink
Add npm script to run http-server #969 (#971)
Browse files Browse the repository at this point in the history
* Signed off by @ankur12-1610
  • Loading branch information
ankur12-1610 authored Mar 8, 2023
1 parent 6792f81 commit 74690b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ Please follow these guidelines when contributing:
supported via a polyfill;
- Do not prettify code you are not working on;
- You must test your code yourself before asking for review, like this:
- set up a local Web server (we recommend Node/NPM's [http-server](https://www.npmjs.com/package/http-server));
- serve the root directory of the repository (e.g. `http-server .`);
- set up a local Web server: we recommend Node/NPM's [http-server](https://www.npmjs.com/package/http-server)), which you can launch by running `npm run serve` in the root of this repository;
- in a browser, navigate to the URL of the main `index.html` (e.g. http://localhost:8080/www/index.html);
- manually test your fix in at least Firefox and Chromium (Edge or Chrome), ideally also in IE11 or in "IE Mode" in Edge;
- be sure to test your fix in both "JQuery" mode and "Service Worker" mode (see Configuration);
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"private": true,
"scripts": {
"serve": "http-server .",
"test": "npm run test-unit-local",
"test-unit-local": "karma start tests/karma.conf.local.js",
"test-unit-firefox": "karma start tests/karma.conf.local.js --browsers FirefoxHeadless",
Expand Down

0 comments on commit 74690b8

Please sign in to comment.