Added http-server script

[ankur12-1610]

Fixes: #969

[ankur12-1610]

@Jaifroid kindly review :)

Also, we might need to update the documentation as well: this is the link of the same

[Jaifroid]

@ankur12-1610 Thank you for this PR. I tested by running npm install --save-dev and then npm start, and the server does indeed start. However, I already have http-server installed globally. Do you know if this would work when it is not installed? I would have thought we'd need to have it listed as a developer dependency in the json, but I haven't tested that scenario. It could be tested in Windows Sandbox or another clean testbed.

Regarding your suggestion to update the documentation, I think that would be part of this PR, but should be done once the above question is tested.

Finally, I'm not sure npm start is the best choice because it is the standard script for launching an Electron app, and Electron is enabled downstream in kiwix-js-windows repository (which depends on this repository).

Perhaps serve would be better, and then the start command would be npm run serve. What do you think?

[ankur12-1610]

@ankur12-1610 Thank you for this PR. I tested by running npm install --save-dev and then npm start, and the server does indeed start. However, I already have http-server installed globally. Do you know if this would work when it is not installed? I would have thought we'd need to have it listed as a developer dependency in the json, but I haven't tested that scenario. It could be tested in Windows Sandbox or another clean testbed.

Regarding your suggestion to update the documentation, I think that would be part of this PR, but should be done once the above question is tested.

Finally, I'm not sure npm start is the best choice because it is the standard script for launching an Electron app, and Electron is enabled downstream in kiwix-js-windows repository (which depends on this repository).

Perhaps serve would be better, and then the start command would be npm run serve. What do you think?

Hey @Jaifroid, I've tested it in MacOS and it works perfectly fine in it. I'll it in try other operating systems as well.

Regarding the dependency, we already have included http-server in package.json.

Also, updated the PR now it is npm run serve and I've updated the docs as well.

The only final step left is verification :)

[Jaifroid]

@ankur12-1610 Thank you, this looks good. I tested launching the server also, and it seems to work fine.

Do you know whether http-server gets installed if a user hasn't installed it globally? You had originally mentioned perhaps needing to run it with npx. I wasn't able to test this because I have it installed globally.

I have one suggestions below. You can use the GitHub buttons to commit the suggestion if you think it's OK.

[ankur12-1610]

@ankur12-1610 Thank you, this looks good. I tested launching the server also, and it seems to work fine.

Do you know whether http-server gets installed if a user hasn't installed it globally? You had originally mentioned perhaps needing to run it with npx. I wasn't able to test this because I have it installed globally.

I have one suggestions below. You can use the GitHub buttons to commit the suggestion if you think it's OK.

Yeah I tested it without installing http-server globally in a new environment, npm install does the work for the user so using npx isn't necessary.

Sure I'll do it👍

[Jaifroid]

Great! So I think this can be squashed and merged. Just confirm that it's ready and I'll press the button (I assume you don't have access to the Squash and merge button on this page).

[ankur12-1610]

Great! So I think this can be squashed and merged. Just confirm that it's ready and I'll press the button (I assume you don't have access to the Squash and merge button on this page).

Yeah LGTM! as well. Yeah I don't have access to squash and merge, although I do have an access to close PR xD