Do not assume urlPtrPos is just after mimeList when reading it #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 1, 2020
Jaifroid
deleted the
Do-not-assume-urlPtrPos-is-just-after-mimeList-when-reading-it
branch
This was referenced Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #628 and #629 (partially) and #621 . It restores the ability of the app to read the MIME type list in newer ZIMs which have relocated the urlPtrPos to the end of the archive. The same solution has been adopted in libZim - see openzim/libzim#353. The solution is to limit the maximum size of the slice being searched for the MIME type list to 1024 bytes. If the ZIM reports it as being less than that, then the lower value is accepted.