promoting webhook service name in the logger

[pritidesai]

Changes

I came across this NOTE while troubleshooting #3206.

The NOTE has reference to issue in knative eventing which is fixed now: knative/eventing#4530

We already have a configuration in webhook.yaml to configure service name and defaulting to tekton-pipelines-webhook if not specified.

Now, instead of hardcoding "webhook-pipeline", reading it from the env if specified to be consistent.

Please note that the webhook logs will now have the consistent service name in the logs, i.e. "logger":"tekton-pipelines-webhook.*" or the name specified in WEBHOOK_SERVICE_NAME env. variable instead of "logger":"webhook-pipeline.*"

e.g.

Before:

{"level":"info","ts":"2021-02-02T01:23:41.115Z","logger":"webhook-pipeline.ValidationWebhook","caller":"controller/controller.go:530","msg":"Reconcile succeeded","commit":"9751b95","knative.dev/traceid":"ddfcbe3c-5efb-42fe-a171-bac521072674","knative.dev/key":"validation.webhook.pipeline.tekton.dev","duration":0.0131361}

After:

{"level":"info","ts":"2021-02-02T01:23:41.115Z","logger":"tekton-pipelines-webhook.ValidationWebhook","caller":"controller/controller.go:530","msg":"Reconcile succeeded","commit":"9751b95","knative.dev/traceid":"ddfcbe3c-5efb-42fe-a171-bac521072674","knative.dev/key":"validation.webhook.pipeline.tekton.dev","duration":0.0131361}

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Promoting webhook service name in the logger instead of always defaulting to "webhook-pipeline". The service name is read from the env. variable `WEBHOOK_SERVICE_NAME` if specified else defaults to "tekton-pipelines-webhook"

[afrittoli]

Nice, thank you!
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ghost]

/lgtm

[pritidesai]

This change partially fixed #2987