[RECOMMENDED] introduce actualReplicas & desiredReplicas #71
Conversation
knative-prow-robot
added
the
size/S
|
cc @knative/trademark-committee |
dprotaso
changed the title
| </td> | ||
| <td>int | ||
| </td> | ||
| <td>Reflects the number of replicas that are running this revision. |
There was a problem hiding this comment.
do we need to be clear about whether this is "ready" replicas vs "existing" replicas in any state?
There was a problem hiding this comment.
I don't think the word Ready would have meaning here without more definition. That's why I left the verbiage as running this revision
There was a problem hiding this comment.
What was the original reason for adding these? I have a vague recollection that we added it so that we didn't rely on the Deployment's metadata to maintain Knative's desired state of the world - and then we'd reflect that down into the Deployment. So, I guess if that's all it is and there's no assumption as to state of the underlying "pods" (rather it's just implying that we're "trying" to bring up X of them), is this your thinking too?
|
+1 |
|
rebase needed |
knative-prow-robot
added
the
needs-rebase
|
Should the actual/desired replica count be tied to the ContainerStatus? IOW should we be extending ContainerStatus with this count or the Revision? Basically, do we need to account for mixed containers running? |
|
/lgtm |
|
Discussed why we can't do this in the ContainerStatus property in KTC and it makes sense that this change is a view into the autoscaler vs a view into the pod-level tracking of containers, so will lgtm |
|
/LGTM |
|
/approve |
omerbensaadon
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dprotaso, omerbensaadon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
requirement levels for these are RECOMMENDED it allows for distributions to signal some additional status regarding the scale of their revisions
dprotaso
force-pushed
the
replica-count
branch
from
9234a0c to
fe0eea8
Compare
knative-prow-robot
removed
lgtm
|
/lgtm |
requirement levels for these are RECOMMENDED
it allows for distributions to signal some additional status regarding
the scale of their revisions