Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECOMMENDED] introduce actualReplicas & desiredReplicas #71

Merged
merged 1 commit into from
Sep 23, 2021
Merged

[RECOMMENDED] introduce actualReplicas & desiredReplicas #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions specs/serving/knative-api-specification-1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,26 @@ constitutes a request.
<td>RECOMMENDED
</td>
</tr>
<tr>
<td><code>actualReplicas</code>
</td>
<td>int
</td>
<td>Reflects the number of replicas that are running this revision.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to be clear about whether this is "ready" replicas vs "existing" replicas in any state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the word Ready would have meaning here without more definition. That's why I left the verbiage as running this revision

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the original reason for adding these? I have a vague recollection that we added it so that we didn't rely on the Deployment's metadata to maintain Knative's desired state of the world - and then we'd reflect that down into the Deployment. So, I guess if that's all it is and there's no assumption as to state of the underlying "pods" (rather it's just implying that we're "trying" to bring up X of them), is this your thinking too?

</td>
<td>RECOMMENDED
</td>
</tr>
<tr>
<td><code>desiredReplicas</code>
</td>
<td>int
</td>
<td>Reflects the desired amount of replicas for this revision.
</td>
<td>RECOMMENDED
</td>
</tr>
</table>

# Detailed Resource Types - v1
Expand Down