Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Decorate backtrace with location information (file+line) #17

Closed
jonas-schievink opened this issue Aug 19, 2020 · 0 comments · Fixed by #63
Closed

Decorate backtrace with location information (file+line) #17

jonas-schievink opened this issue Aug 19, 2020 · 0 comments · Fixed by #63
Assignees
@japaric
Labels
type: enhancement Enhancement or feature request

Comments

@jonas-schievink
Copy link
Contributor

The libstd implementation prints file and line number for each (non-inlined) call in the backtrace. We should do the same, as it makes finding the relevant locations easier.

If the format is right, VS Code should even make the locations clickable.
@jonas-schievink jonas-schievink added the type: enhancement Enhancement or feature request label Aug 19, 2020
@japaric japaric self-assigned this Sep 8, 2020
japaric added a commit that referenced this issue Sep 16, 2020
@japaric
start using DWARF info in the unwinder
31ce891 
this is works towards #17
for now it extends the backtrace with inlined functions (which were not shown
before)
it doesn't add line info just yet though there is some, no super-precise line
info available
@japaric japaric mentioned this issue Sep 16, 2020
Merged
japaric added a commit that referenced this issue Sep 16, 2020
@japaric
start using DWARF info in the unwinder
4865413 
this is works towards #17
for now it extends the backtrace with inlined functions (which were not shown
before)
it doesn't add line info just yet though there is some, no super-precise line
info available
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@japaric japaric

Labels
type: enhancement Enhancement or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add location info to the backtrace knurling-rs/probe-run
2 participants
@jonas-schievink @japaric