This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
add location info to the backtrace #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is works towards #17 for now it extends the backtrace with inlined functions (which were not shown before) it doesn't add line info just yet though there is some, no super-precise line info available
japaric
force-pushed
the
unwind-dwarf
branch
from
31ce891 to
39c25a2
Compare
japaric
changed the title
japaric
commented
Sep 17, 2020
| let subroutine = frames | ||
| .last() | ||
| .expect("BUG: `addr2line::FrameIter` was empty"); | ||
| let has_valid_debuginfo = if let Some(function) = subroutine.function.as_ref() { |
There was a problem hiding this comment.
without this workaround addr2line was reporting __udivmodsi4 as the first frame of the backtrace.
jonas-schievink
approved these changes
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17