-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark code fixed -- Port & nest() were not working #51
Benchmark code fixed -- Port & nest() were not working #51
Conversation
Did you want to put |
I was up in the air, I had to brew install wrk for this to operate properly. Weirdly .nest() was giving me an issue though I saw that you had fixed it. |
Update Local
branch with updated master for-loop refactor
- New config will not require dev to install wrk with brew or global NPM - scripts will be improved for perfing
I added the Eventually, I want to improve the perfing tooling/code and make it more usable maybe even integrate something like a perf/health check into Travis or something. I think those can be done in other PR's though. |
lmk if this is ready? |
Ready. |
@JacobMGEvans Could we use |
@niftylettuce which would also allow for more environment variables to be dynamic and with hardcoded fallbacks. |
* benchmark code fixed -- Port & nest() were not working * Added work to DevDepends and will change scripts - New config will not require dev to install wrk with brew or global NPM - scripts will be improved for perfing
wrk
needs to be installed locally or alternatively it can be installed into dev dependencies.related to #52