Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Build Failure Fix #62

Merged
merged 10 commits into from
Feb 24, 2020
Merged

Conversation

JacobMGEvans
Copy link
Contributor

  • Updated the Node versions in Travis file
  • Build should pass with new configurations

resolves #61

@JacobMGEvans
Copy link
Contributor Author

I apparently used the branch I did the benchmark code fixes on from the PR #60
I can close this PR and make another from master once #60 goes into master

@niftylettuce niftylettuce merged commit 759120a into koajs:master Feb 24, 2020
JacobMGEvans added a commit to JacobMGEvans/router that referenced this pull request Mar 14, 2020
* Environment set and dynamic

* Removed local setting file added by mistake

* Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

* Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

* clarify the number output meaning

* Travis Node versions updated

* More Versions in Travis Build
JacobMGEvans added a commit to JacobMGEvans/router that referenced this pull request Mar 14, 2020
* Environment set and dynamic

* Removed local setting file added by mistake

* Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

* Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

* clarify the number output meaning

* Travis Node versions updated

* More Versions in Travis Build

Environment set and dynamic

Removed local setting file added by mistake

Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

clarify the number output meaning
JacobMGEvans added a commit to JacobMGEvans/router that referenced this pull request Mar 14, 2020
* Environment set and dynamic

* Removed local setting file added by mistake

* Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

* Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

* clarify the number output meaning

* Travis Node versions updated

* More Versions in Travis Build

Environment set and dynamic

Removed local setting file added by mistake

Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

clarify the number output meaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis Node Version Support Update
2 participants