Remove action buttons on expired offer

[exezbcz]

• The cancel and accept button should not be visible in case of expired offer

[kodabot]

ASSIGNED - @prachi00 🔒 LOCKED -> Monday, March 27th 2023, 09:56:06 UTC -> 36 hours

[roiLeo]

@exezbcz this is done on purposes to let user "CANCEL" offer even when expired because this offer balance is frozen until it's accepted or removed. (ref #3582, #766)

But "Accept" button shouldn't be allowed here.

[yangwao]

this offer balance is frozen until it's accepted or removed.

I think it's balance is locked there, but from bid author and can be withdraw anytime iirc.

What "CANCEL" would trigger on-chain for funds which are not owned by user?

Maybe @vikiival can bring some light, because I think only action you can do is to accept bid, you can't do anything else with incoming bid.

CANCEL issues some sort of on-chain message to bidder or how will see it?

Other hand I would be surprised if Basilisk has this?

[vikiival]

As @roiLeo pointed out correctly offer can be canceled by offer maker or current NFT owner

What is happening on on-chain side is calling marketplace.withdrawOffer(collectionId, tokenId, makerAddress)

Pallet then checks if creator of tx is one of them

https://github.com/galacticcouncil/Basilisk-node/blob/master/pallets/marketplace/src/lib.rs

L236

If owner cancels a bid, there is currently no notification for the user, but can be implemented via subsquid

[exezbcz]

If owner cancels a bid, there is currently no notification for the user, but can be implemented via subsquid

• Simple notification screen #4890

yes! I forgot to add it - is it possible to make like counter for the offer instead of cancel? That would be maybe more useful than canceling it