Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5378 expired check #5381

Merged
merged 3 commits into from
Mar 28, 2023
Merged

#5378 expired check #5381

merged 3 commits into from
Mar 28, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 25, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner March 25, 2023 22:28
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team March 25, 2023 22:28
@kodabot
Copy link
Collaborator

kodabot commented Mar 25, 2023

SUCCESS @prachi00 PR for issue #5378 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 25, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 316091d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6422ecbaa6e50100083240bf
😎 Deploy Preview https://deploy-preview-5381--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Mar 26, 2023

Cant test this one anymore so if the code is legit I give it a green light

@prachi00 prachi00 requested a review from Jarsen136 March 26, 2023 22:08
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 27, 2023
roiLeo
roiLeo suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this one until we find a way to remove expired offers

@vikiival
Copy link
Member

Please don't merge this one until we find a way to remove expired offers

kodadot/snek#13

@vikiival
Copy link
Member

pay 15 usd

@vikiival vikiival enabled auto-merge March 28, 2023 13:33
@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023

Code Climate has analyzed commit 316091d and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival disabled auto-merge March 28, 2023 15:53
@vikiival vikiival merged commit c1f4427 into main Mar 28, 2023
@vikiival vikiival deleted the feat-expired-check branch March 28, 2023 15:53
@prachi00 prachi00 mentioned this pull request Mar 28, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.05 USD/DOT ~ 3.96 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x1433b3520cc6c09ab563fc60faae8eac80d1b878fe86160ad5218087600e8b94

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo requested changes

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove action buttons on expired offer
8 participants
@prachi00 @kodabot @exezbcz @vikiival @yangwao @preschian @roiLeo @Jarsen136