Asset-hub-royalties #7816

daiagi · 2023-10-25T02:54:20Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes Royalties on Asset Hub #7733
Requires deployment - stick
won't work until 🔧 nft create form #7771 is merged

royalties stick#132

Did your issue had any of the "$" label on it?

$

My DOT address: Payout

Related transacrions

tx with set attributes (on chain royalty)
https://assethub-kusama.subscan.io/extrinsic/5640724-2
buy single item with royalty
https://assethub-kusama.subscan.io/extrinsic/5640390-2
buy 3 items with royalties (shopping cart)
https://assethub-kusama.subscan.io/extrinsic/5645506-2

items minted with royalty:

/ahk/gallery/12-10
/ahk/gallery/12-11
/ahk/gallery/12-12

My fix has changed UI

Copilot Summary

`🤖 Generated by Copilot at b6f31df`

This pull request adds and improves the functionality for handling royalties on different chains and NFT standards. It enables minting and paying royalties on Statemine, toggles Rmrk-specific features based on the chain, and refactors the code for verifying and normalizing royalty data. It affects the files CreateNft.vue, transactionMintStatemine.ts, transactionBuy.ts, useIsChain.ts, support.ts, and utils.ts.

`🤖 Generated by Copilot at b6f31df`

Sing, O Muse, of the crafty developers who wrought
New features for the NFT marketplace, and sought
To honor the creators with royaltyFee and payTips
And to validate their data with verifyRoyalty and isRmrk scripts.

kodabot · 2023-10-25T02:54:25Z

WARNING @daiagi PR for issue #7733 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7733

netlify · 2023-10-25T02:54:25Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`dc512ec`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/653a2a2337ee3c00083d9ff8
😎 Deploy Preview	https://deploy-preview-7816--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codeclimate · 2023-10-25T02:54:47Z

composables/transaction/transactionBuy.ts

+import { verifyRoyalty } from './utils'
+
+function payRoyaltyAssetHub(
+  legacy,


Function payRoyaltyAssetHub has 6 arguments (exceeds 4 allowed). Consider refactoring.

reviewpad · 2023-10-25T02:54:57Z

AI-Generated Summary: This pull request includes 3 patches.

The first patch modifies the CreateNft.vue and useIsChain.ts components to show the royalty field for all chains except rmrk. The changes include adding a new computed value isRmrk in useIsChain, and using it to control the display of the royalty field in CreateNft.vue.
The second patch affects the transactionMintStatemine.ts file to set royalty attributes during token minting. The minting function now checks whether the token has royalty enabled and properly set. If it does, two additional transaction methods for setting the royalty amount and recipient are included in the transaction execution.
The third and final patch mainly affects the transactionBuy.ts component and introduces a new function payRoyaltyAssetHub. This function calculates and initiates a transaction to pay royalties when a token is bought. There are also updates to the execBuyRmrk, execBuyBasilisk and execBuyStatemine functions to include the royalty payment process in the buying operation.

On the whole, these changes thus deal with the implementation of royalty payments for NFTs across different chains.

roiLeo

otherwise code lgtm

utils/support.ts

vikiival

~

composables/useIsChain.ts

vikiival · 2023-10-25T07:20:22Z

composables/transaction/transactionBuy.ts

+    : api.tx.nfts.payTips([
+        {
+          collection: collectionId,
+          item: tokenId,
+          receiver: normalizedRoyalty.address,
+          amount: royaltyFee(price, normalizedRoyalty.amount),
+        },


move to utils?

i don't see the value in it
you will have a function with 4 params plus API

why not just use api.tx.nfts.payTips directly?

…set-hub-royalties

daiagi · 2023-10-25T14:19:53Z

@prury pleae note that royalty can only be whole numbers (integers) until new squid is released
@vikiival

…set-hub-royalties

vikiival · 2023-10-25T15:11:47Z

@prury pleae note that royalty can only be whole numbers (integers) until new squid is released
@vikiival

It is posible to do that automatized way

kodadot/stick@release-squid...main

daiagi · 2023-10-25T15:16:19Z

It is posible to do that automatized way

thought so but didn't want to step in and do it without your consent

vikiival · 2023-10-25T15:17:15Z

It is posible to do that automatized way

thought so but didn't want to step in and do it without your consent

Still can tag me ^-^

prury · 2023-10-25T15:29:40Z

Ahk - custom royalties only
https://deploy-preview-7816--koda-canary.netlify.app/ahk/gallery/172-4
Ahp - custom royalty specifying address
https://deploy-preview-7816--koda-canary.netlify.app/ahp/gallery/14-3

Set @daiagi to receive 5% royalties, bought NFT from myself on AssetHub and value got sent to him
https://deploy-preview-7816--koda-canary.netlify.app/ahp/gallery/14-3

AshutoshSingh72 · 2023-10-26T03:11:23Z

@vikiival what ? He is adding royalty to each nft unless of adding into the collection

vikiival · 2023-10-26T08:14:18Z

@vikiival what ? He is adding royalty to each nft unless of adding into the collection

Sir I do not understand what you mean.
can you please rephrase?

codeclimate · 2023-10-26T08:58:36Z

Code Climate has analyzed commit dc512ec and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3

View more on Code Climate.

sonarqubecloud · 2023-10-26T08:58:37Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

roiLeo · 2023-10-26T12:09:37Z

tests/e2e/footer.spec.ts

+  // {
+  //   linkName: 'Instagram',
+  //   linkAddress: 'https://www.instagram.com/kodadot.xyz/',
+  // },


let's fix it in another PR or maybe @prury has an idea?

let's fix it in another PR or maybe @prury has an idea?

can we leave it like that and I'll apply a proper fix in another PR?

yangwao · 2023-10-26T12:57:03Z

Thanks!
pay 50 usd

yangwao · 2023-10-26T12:57:16Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.34 USD/DOT ~ 11.521 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x05c0694ad469c351f39e4db307e6bb0f1819d40bb35625e221b4fd6a41e24429

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

daiagi added 3 commits October 25, 2023 09:44

show royalty field on all except rmrk

8127102

set royalty attributes on nft (mint)

89ab6f5

pay royalty tx

b6f31df

daiagi requested a review from a team as a code owner October 25, 2023 02:54

daiagi requested review from preschian and floyd-li and removed request for a team October 25, 2023 02:54

daiagi requested review from roiLeo and vikiival and removed request for floyd-li October 25, 2023 02:54

codeclimate bot reviewed Oct 25, 2023

View reviewed changes

reviewpad bot added medium Pull request is medium waiting-for-review labels Oct 25, 2023

roiLeo approved these changes Oct 25, 2023

View reviewed changes

utils/support.ts Outdated Show resolved Hide resolved

daiagi added 2 commits October 25, 2023 14:17

shape of royaltyFee

e8d7c55

Merge branch 'main' into asset-hub-royalties

9e24aa0

vikiival reviewed Oct 25, 2023

View reviewed changes

daiagi added 3 commits October 25, 2023 17:14

Merge branch 'main' into asset-hub-royalties

7a39d83

Merge branch 'main' of https://github.com/kodadot/nft-gallery into as…

4e888d1

…set-hub-royalties

delete isKsm export

86df7d2

daiagi added 2 commits October 25, 2023 21:29

Merge branch 'main' of https://github.com/kodadot/nft-gallery into as…

479bbc9

…set-hub-royalties

commetn out instagram link in test as @prury suggested

c0e8165

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 25, 2023

Merge branch 'main' into asset-hub-royalties

dc512ec

roiLeo reviewed Oct 26, 2023

View reviewed changes

yangwao merged commit ba7d603 into main Oct 26, 2023
11 checks passed

yangwao deleted the asset-hub-royalties branch October 26, 2023 12:57

yangwao added the paid pull-request has been paid label Oct 26, 2023

This was referenced Oct 26, 2023

beta update #7831

Merged

release update #7832

Closed

release update #7834

Merged

beta update #7872

Merged

release update #7873

Merged

daiagi mentioned this pull request Dec 14, 2023

Royalties are not paid on AssetHub #8511

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asset-hub-royalties #7816

Asset-hub-royalties #7816

daiagi commented Oct 25, 2023 •

edited

Loading

kodabot commented Oct 25, 2023

netlify bot commented Oct 25, 2023 •

edited

Loading

codeclimate bot Oct 25, 2023

reviewpad bot commented Oct 25, 2023

roiLeo left a comment

vikiival left a comment

vikiival Oct 25, 2023

daiagi Oct 25, 2023

daiagi commented Oct 25, 2023

vikiival commented Oct 25, 2023

daiagi commented Oct 25, 2023

vikiival commented Oct 25, 2023

prury commented Oct 25, 2023 •

edited

Loading

AshutoshSingh72 commented Oct 26, 2023

vikiival commented Oct 26, 2023

codeclimate bot commented Oct 26, 2023

sonarqubecloud bot commented Oct 26, 2023

roiLeo Oct 26, 2023

prury Oct 26, 2023

yangwao commented Oct 26, 2023

yangwao commented Oct 26, 2023

Asset-hub-royalties #7816

Asset-hub-royalties #7816

Conversation

daiagi commented Oct 25, 2023 • edited Loading

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Related transacrions

items minted with royalty:

Copilot Summary

🤖 Generated by Copilot at b6f31df

🤖 Generated by Copilot at b6f31df

kodabot commented Oct 25, 2023

netlify bot commented Oct 25, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

codeclimate bot Oct 25, 2023

Choose a reason for hiding this comment

reviewpad bot commented Oct 25, 2023

roiLeo left a comment

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

vikiival Oct 25, 2023

Choose a reason for hiding this comment

daiagi Oct 25, 2023

Choose a reason for hiding this comment

daiagi commented Oct 25, 2023

vikiival commented Oct 25, 2023

daiagi commented Oct 25, 2023

vikiival commented Oct 25, 2023

prury commented Oct 25, 2023 • edited Loading

AshutoshSingh72 commented Oct 26, 2023

vikiival commented Oct 26, 2023

codeclimate bot commented Oct 26, 2023

sonarqubecloud bot commented Oct 26, 2023

roiLeo Oct 26, 2023

Choose a reason for hiding this comment

prury Oct 26, 2023

Choose a reason for hiding this comment

yangwao commented Oct 26, 2023

yangwao commented Oct 26, 2023

daiagi commented Oct 25, 2023 •

edited

Loading

`🤖 Generated by Copilot at b6f31df`

`🤖 Generated by Copilot at b6f31df`

netlify bot commented Oct 25, 2023 •

edited

Loading

prury commented Oct 25, 2023 •

edited

Loading