Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

royalties #132

Merged
merged 2 commits into from
Oct 25, 2023
Merged

royalties #132

merged 2 commits into from
Oct 25, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Oct 25, 2023

  • save royalty as float instead of int
  • don't save royalty into attributes

related with

@daiagi daiagi changed the title Ahk-royalties royalties Oct 25, 2023
@daiagi daiagi requested a review from vikiival October 25, 2023 02:18
@daiagi daiagi mentioned this pull request Oct 25, 2023
Merged
8 tasks
@vikiival vikiival merged commit 74fda95 into kodadot:main Oct 25, 2023
1 check passed
roiLeo
roiLeo reviewed Oct 25, 2023
View reviewed changes
src/mappings/nfts/setAttribute.ts
@@ -32,7 +30,7 @@ export async function handleAttributeSet(context: Context): Promise<void> {
const attribute = final.attributes?.find((attr) => attr.trait === event.trait)
if (attribute) {
attribute.value = String(event.value)
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can review one more time

This was referenced Oct 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@roiLeo roiLeo roiLeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daiagi @roiLeo @vikiival