Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix module name for exp special data type #743

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

nankolena
Copy link
Contributor

Linked issue(s)

N/A

What change does this PR introduce and why?

See #742 (comment)

Bug from finding the module for special datatypes. Downloading a dataset that has timestamp classes will lead to:
Failed to import module for data type 'SPECIAL/TIMESTAMP'

This originates from this commit that moved the module but the refactoring did not find this literal string match.

Testing:

Using the following code on my trunk workspace:

from kolena.dataset import download_dataset

df = download_dataset("financebench", include_extracted_properties=True)

On trunk, I see kolena> Failed to import module for data type 'SPECIAL/TIMESTAMP'

With the change, df download is successful. Example data:

print(df["labeling_task"].tail(1))


149    {'answer': 'The three main companies acquired by Pfizer mentioned in this 10-K report are:

1. Medivation, Inc.
2. Hospira, Inc.
3. Anacor Pharmaceuticals, Inc.', 'labeler': '[email protected]', 'task_name': 'hgfsfdsaadfs', 'timestamp': Timestamp(epoch_time=1736887455.0, value=None, format=None)}
Name: labeling_task, dtype: object

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@nankolena nankolena requested a review from a team as a code owner January 15, 2025 21:15
@nankolena nankolena merged commit 81fe74f into trunk Jan 15, 2025
57 checks passed
@nankolena nankolena deleted the nan/fix-timestamp-deserial branch January 15, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants