-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis installs Chrome 74 and Dusk needs 70-73 #126
Comments
I will se if I can get Travis to install Chrome 73 |
Unfortunately, a specific version can't be selected, see https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version |
I tried installing https://github.com/staudenmeir/dusk-updater but of course it doesn't work, we're in a package so don't have artisan available... 😝 |
I can't come up with a way to solve this issue. I guess we'll have to turn off strict Travis checks here on GitHub to allow merging into master. |
I've disabled "Require status checks to pass before merging" on https://github.com/kontenta/kontour/settings/branch_protection_rules/2125408 You can still run tests locally, so we'll need to be prudent and run tests before merging @erik-epineer ! |
Looks like Testbench is givning this issue some attention now! Lets try the suggested way of running the command from the vendor dir! orchestral/testbench-dusk#37 |
@bjuppa https://github.com/orchestral/dusk-updater (from the issue in Testbench Dusk that you highlighted) see the travis.yml for testbench-dusk (https://github.com/orchestral/testbench-dusk/blob/36f443e14fa553f19c79ddd20f6864cd7335f778/.travis.yml#L31) for sample usage |
@erik-epineer The latest releases of I will soon create a PR that restricts our deps to those versions and that makes sure to run the new |
@bjuppa super, thanks! |
The CI currently fails because of incompatibility with latest Chrome, see
laravel/dusk#641
The text was updated successfully, but these errors were encountered: