Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis installs Chrome 74 and Dusk needs 70-73 #126

Closed
bjuppa opened this issue Apr 25, 2019 · 10 comments
Closed

Travis installs Chrome 74 and Dusk needs 70-73 #126

bjuppa opened this issue Apr 25, 2019 · 10 comments
Assignees

Comments

@bjuppa
Copy link
Member

bjuppa commented Apr 25, 2019

The CI currently fails because of incompatibility with latest Chrome, see
laravel/dusk#641

@bjuppa
Copy link
Member Author

bjuppa commented Apr 25, 2019

I will se if I can get Travis to install Chrome 73

@bjuppa bjuppa self-assigned this Apr 25, 2019
@bjuppa
Copy link
Member Author

bjuppa commented Apr 25, 2019

Unfortunately, a specific version can't be selected, see https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version

@bjuppa
Copy link
Member Author

bjuppa commented Apr 25, 2019

I tried installing https://github.com/staudenmeir/dusk-updater but of course it doesn't work, we're in a package so don't have artisan available... 😝

@bjuppa
Copy link
Member Author

bjuppa commented Apr 25, 2019

I can't come up with a way to solve this issue.

I guess we'll have to turn off strict Travis checks here on GitHub to allow merging into master.

@bjuppa bjuppa changed the title Travis installs chrome 74 and Dusk needs 70-73 Travis installs Chrome 74 and Dusk needs 70-73 Apr 25, 2019
@bjuppa
Copy link
Member Author

bjuppa commented Apr 25, 2019

I've disabled "Require status checks to pass before merging" on https://github.com/kontenta/kontour/settings/branch_protection_rules/2125408
so we can now merge even though the Travis builds are failing.

You can still run tests locally, so we'll need to be prudent and run tests before merging @erik-epineer !

@bjuppa
Copy link
Member Author

bjuppa commented May 8, 2019

Looks like Testbench is givning this issue some attention now! Lets try the suggested way of running the command from the vendor dir! orchestral/testbench-dusk#37

@Keoghan
Copy link

Keoghan commented May 9, 2019

@bjuppa https://github.com/orchestral/dusk-updater (from the issue in Testbench Dusk that you highlighted)

see the travis.yml for testbench-dusk (https://github.com/orchestral/testbench-dusk/blob/36f443e14fa553f19c79ddd20f6864cd7335f778/.travis.yml#L31) for sample usage

@bjuppa
Copy link
Member Author

bjuppa commented May 10, 2019

@erik-epineer The latest releases of testbench-dusk so kindly provided by @Keoghan & @crynobone (thanks a million!) now solves our problems with Chrome versions, so I've turned strict Travis status checks on again for this repo!

I will soon create a PR that restricts our deps to those versions and that makes sure to run the new dusk-updater command before our Travis tests!

bjuppa added a commit that referenced this issue May 10, 2019
@bjuppa
Copy link
Member Author

bjuppa commented May 10, 2019

@Keoghan if you should run into problems with xvfb with that Travis setup you linked to above, you can see how we did to get it working again here:
17a1966

@Keoghan
Copy link

Keoghan commented May 10, 2019

@bjuppa super, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants