-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on toml-v0.4.0
example
#206
Comments
@leptonyu Thanks for reporting the issue! That was unexpected 😕 We will improve our test-suite and fix the bug. Could you also provide the link to your tests, so we can test before releasing a new version to Hackage? /cc @jiegillet |
My tests file was copied from the offical toml-lang repo. Here are the link. |
toml-v0.4.0
example
@leptonyu Nice to have an example! I've changed the title of this issue to implement more robust testing. |
Sorry about that. For this specific issue, adding a I have one uncertainty about this situation though. Should [table.inline]
name = { first = "Tom", last = "Preston-Werner" }
point = { x = 1, y = 2 } be interpreted as one table
Following this definition, the table should be three different tables right? That's what my parser does (and will do correctly as soon as I fix the current issue). I think this is correct but I never found a satisfying explicit answer or counter-example. What do you think? |
Reviewing the following issue, I think you are right. The motivation of inline tables is not to supporting sub tables, but to simplify tables. |
Thanks for looking into it! |
* [#206] Test on toml-v0.4.0 example * Added offical TOML examples as tests * Added unit tests for specific issue * CHANGELOG * Update CHANGELOG.md Co-Authored-By: Dmitrii Kovanikov <[email protected]> * listDirectory instead of hardcoded paths
@leptonyu This was fixed by @jiegillet. I've uploaded |
My tests has the above inline block, it fails by using
tomland-1.1.0.0
The text was updated successfully, but these errors were encountered: