[#206] Test on toml-v0.4.0 example #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegillet
added
bug
|
One of the checks failed because of the issue described in #198 (same-level tables with common subkeys) |
chshersh
reviewed
Jul 10, 2019
test/Test/Toml/Parsing/Examples.hs
Outdated
|
|
||
| files :: [FilePath] | ||
| files = | ||
| [ "fruit.toml" |
There was a problem hiding this comment.
I propose to use listDirectory function inside tests to avoid hardcoding of test cases:
You can use runIO function from hspec to run IO actions inside Spec monad:
There was a problem hiding this comment.
I looked into runIO when I was figuring out how to read files in a Spec but then I realized it can handle it just fine, I think I'll leave it like this.
There was a problem hiding this comment.
Never mind, I guess it's necessary if I want to use listDirectory. On it.
Co-Authored-By: Dmitrii Kovanikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #206. I apologize for letting that slip through me to begin with.
I don't have much experience with
hspec, please let me know if I did something strange.