Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped npm packages #38

Closed
4 tasks done
kristoforsalmin opened this issue May 15, 2018 · 4 comments · Fixed by #52
Closed
4 tasks done

Scoped npm packages #38

kristoforsalmin opened this issue May 15, 2018 · 4 comments · Fixed by #52

Comments

@kristoforsalmin
Copy link

kristoforsalmin commented May 15, 2018

Hi everyone,

What do you think about moving all our packages under kraftvaerk scope?

I'm a bit uncertain about shareable configs, because I think it makes sense to use same name for repo and npm package, so maybe we can just stick to what we currently have (e.g. @kraftvaerk/eslint-config-kraftvaerk).

@mi2oon
Copy link
Member

mi2oon commented Sep 12, 2018

@racse1 I would love that.. I'll have a look at the npm part. However, what about the repos on git? Should we then also move to a mono-repo structure?

@kristoforsalmin
Copy link
Author

@mi2oon Well, that's completely up to us. I mean having a scope doesn't force us to go monorepo, does it? 😄 I doubt we actually need a monorepo — our packages can be perfectly used independently and we don't have to fiddle with Lerna or think about structuring issues and pull requests.

If you think it'd be better with monorepo — I'm happy to know why 👍 At the same time I think it's very convenient way of handling large number of, let's say, helpers or components.

@kristoforsalmin
Copy link
Author

Description updated 👆

@mi2oon
Copy link
Member

mi2oon commented Oct 26, 2018

@racse1 Updated little more. I decided to keep things pretty much like today and switched to scoped on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants