Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OSMWayLoader and highway2vec #126

Closed
wants to merge 11 commits into from

Conversation

Calychas
Copy link
Collaborator

No description provided.

@Calychas Calychas linked an issue Nov 30, 2022 that may be closed by this pull request
@Calychas Calychas force-pushed the 80-add-embedder-for-highway2vec-use-case branch from e6d4e82 to c2a7be1 Compare November 30, 2022 17:23
@Calychas Calychas linked an issue Nov 30, 2022 that may be closed by this pull request
@Calychas Calychas changed the title feat: OSMnxWayLoader and Highway2Vec notebook OSMWayLoader and Highway2Vec Dec 7, 2022
@Calychas Calychas force-pushed the 80-add-embedder-for-highway2vec-use-case branch 2 times, most recently from d739126 to 504560e Compare December 7, 2022 20:25
@Calychas Calychas force-pushed the 80-add-embedder-for-highway2vec-use-case branch from 504560e to 7c1a3d7 Compare December 21, 2022 20:15
@Calychas Calychas force-pushed the 80-add-embedder-for-highway2vec-use-case branch from 2a24f1a to 048d611 Compare January 18, 2023 16:54
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #126 (55d7581) into main (4d7f2b9) will decrease coverage by 15.68%.
The diff coverage is 32.89%.

@@             Coverage Diff             @@
##             main     #126       +/-   ##
===========================================
- Coverage   98.13%   82.46%   -15.68%     
===========================================
  Files          20       24        +4     
  Lines         483      633      +150     
===========================================
+ Hits          474      522       +48     
- Misses          9      111      +102     
Flag Coverage Δ
macos-latest-python3.11 82.46% <32.89%> (-15.68%) ⬇️
ubuntu-latest-python3.10 82.30% <32.89%> (-15.63%) ⬇️
ubuntu-latest-python3.11 82.30% <32.89%> (-15.63%) ⬇️
ubuntu-latest-python3.8 82.19% <31.54%> (-15.74%) ⬇️
ubuntu-latest-python3.9 82.19% <31.54%> (-15.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/embedders/base.py 100.00% <ø> (ø)
srai/embedders/count_embedder.py 100.00% <ø> (ø)
srai/joiners/base.py 100.00% <ø> (ø)
srai/joiners/intersection_joiner.py 100.00% <ø> (ø)
srai/loaders/base.py 100.00% <ø> (ø)
srai/loaders/geoparquet_loader.py 100.00% <ø> (ø)
srai/regionizers/_spherical_voronoi.py 100.00% <ø> (ø)
.../regionizers/administrative_boundary_regionizer.py 91.42% <ø> (ø)
srai/regionizers/base.py 100.00% <ø> (ø)
srai/regionizers/h3_regionizer.py 100.00% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Calychas Calychas changed the title OSMWayLoader and Highway2Vec feat: add OSMWayLoader Jan 24, 2023
@Calychas Calychas changed the title feat: add OSMWayLoader feat: add OSMWayLoader and highway2vec Jan 24, 2023
@Calychas
Copy link
Collaborator Author

Closing, as the pull request would become too large. OSMWayLoader and Highway2Vec will now become 2 separate Pull Requests. PR for OSMWayLoader is #166

@Calychas Calychas closed this Jan 25, 2023
@Calychas Calychas deleted the 80-add-embedder-for-highway2vec-use-case branch April 25, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Highway2Vec Add OSMLoader based on osmnx / overpass
1 participant