Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OSMWayLoader #166

Merged
merged 18 commits into from
Mar 22, 2023
Merged

feat: add OSMWayLoader #166

merged 18 commits into from
Mar 22, 2023

Conversation

Calychas
Copy link
Collaborator

Closes #78

@Calychas Calychas added the enhancement New feature or request label Jan 25, 2023
@Calychas Calychas self-assigned this Jan 25, 2023
@Calychas
Copy link
Collaborator Author

Still lacks tests. Will add them soon

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #166 (a173f00) into main (78d0fbb) will increase coverage by 0.27%.
The diff coverage is 97.09%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   93.82%   94.09%   +0.27%     
==========================================
  Files          41       44       +3     
  Lines        1117     1288     +171     
==========================================
+ Hits         1048     1212     +164     
- Misses         69       76       +7     
Flag Coverage Δ
macos-latest-python3.10 ?
ubuntu-latest-python3.10 94.02% <97.09%> (+0.28%) ⬆️
ubuntu-latest-python3.8 94.08% <97.04%> (+0.26%) ⬆️
ubuntu-latest-python3.9 94.00% <97.04%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/exceptions.py 90.00% <83.33%> (-10.00%) ⬇️
srai/loaders/osm_way_loader/osm_way_loader.py 97.31% <97.31%> (ø)
srai/loaders/__init__.py 100.00% <100.00%> (ø)
srai/loaders/osm_way_loader/__init__.py 100.00% <100.00%> (ø)
srai/loaders/osm_way_loader/constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RaczeQ
Copy link
Collaborator

RaczeQ commented Mar 1, 2023

Keep OSM_TAGS definition in the same format as @simonusher provided in hex2vec implementation.

@Calychas Calychas force-pushed the osm-way-loader branch 2 times, most recently from 773f2f4 to 3f362a3 Compare March 14, 2023 22:54
piotrgramacki
piotrgramacki previously approved these changes Mar 21, 2023
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@simonusher simonusher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you a couple of comments about some minor details to change, and a broken import in the example notebook

@Calychas Calychas merged commit 8ebda07 into main Mar 22, 2023
@Calychas Calychas deleted the osm-way-loader branch March 22, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSMLoader based on osmnx / overpass
4 participants