-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OSMWayLoader #166
Conversation
Still lacks tests. Will add them soon |
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 93.82% 94.09% +0.27%
==========================================
Files 41 44 +3
Lines 1117 1288 +171
==========================================
+ Hits 1048 1212 +164
- Misses 69 76 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
58c43e7
to
e5d5c4e
Compare
e5d5c4e
to
4c62a92
Compare
Keep |
773f2f4
to
3f362a3
Compare
eae5b06
to
2c1f637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left you a couple of comments about some minor details to change, and a broken import in the example notebook
Closes #78