Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: setup README #255

Merged
merged 12 commits into from
Apr 27, 2023
Merged

docs: setup README #255

merged 12 commits into from
Apr 27, 2023

Conversation

piotrgramacki
Copy link
Collaborator

Closes #12

@piotrgramacki piotrgramacki linked an issue Apr 26, 2023 that may be closed by this pull request
Setup project metadata and README #12
Closed
RaczeQ
RaczeQ reviewed Apr 27, 2023
View reviewed changes
RaczeQ
RaczeQ reviewed Apr 27, 2023
View reviewed changes
RaczeQ
RaczeQ reviewed Apr 27, 2023
View reviewed changes
RaczeQ
RaczeQ reviewed Apr 27, 2023
View reviewed changes
RaczeQ
RaczeQ requested changes Apr 27, 2023
View reviewed changes
@RaczeQ
Copy link
Collaborator

RaczeQ commented Apr 27, 2023 •
edited
Loading

We need to add some info about using OSM data with attributions:

# example from Valhalla
OpenStreetMap data in the `./test/data` is licensed under [ODbL](https://opendatacommons.org/licenses/odbl/) and [copyrighted](https://www.openstreetmap.org/copyright) by OSM contributors.

or something like this:

The free [OpenStreetMap](https://www.openstreetmap.org/) data, which is used for the development of SRAI, is licensed under the [Open Data Commons Open Database License](https://opendatacommons.org/licenses/odbl/) (ODbL) by the [OpenStreetMap Foundation](https://osmfoundation.org/) (OSMF).

osmnx has it like that:

License

OSMnx is licensed under the MIT license. OpenStreetMap's open data [license](https://www.openstreetmap.org/copyright/) requires that derivative works provide proper attribution.

RaczeQ
RaczeQ reviewed Apr 27, 2023
View reviewed changes
Calychas
Calychas reviewed Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some images!

@Calychas Calychas merged commit 3eb390e into main Apr 27, 2023
@Calychas Calychas deleted the 12-setup-project-metadata-and-readme branch April 27, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaczeQ RaczeQ RaczeQ requested changes

@Calychas Calychas Calychas left review comments

@simonusher simonusher Awaiting requested review from simonusher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup project metadata and README
3 participants
@piotrgramacki @RaczeQ @Calychas