Properly handle Dutch year numbers

[mvz]

Changes the handling of, e.g., 1984, to use nineteenhundred-style instead of one thousand nine hundred.

This solution is slightly hacky at the moment. If this logic makes sense for other languages (English and German, perhaps?) I can create some helper methods.

[jlduran]

Great!

At least for English, I would add an option to pass (e.g. shortened: tue or informal), we do not want a check to bounce because of that 🙃

[jlduran]

This is OK.

I commented about my preferred style, but it is not compulsory. If there are no objections, I should commit it over the weekend.

[jlduran]

This is just a personal preference, how about?:

return super unless figures.number_in_capacity(1) == 1

if figures.hundreds
  teen_hundreds = @figures[2, 2].to_figures
  [([@translations.teens(teen_hundreds), translate(:hundreds, 1)] +
    simple_number_to_words).join]
else
  simple_number_to_words + [translate(:mega, 1)]
end

[mvz]

Yes, that's better. Updated.

[mvz]

I'm going to do do a bit of research on whether in Dutch this change is always good, or only for years.

[mvz]

I'm going to update this PR make this an option.

[mvz]

The teenhundreds style is generally used with years, not so much with other numbers. Still to do:

• Use this also for later years, like 2183
• Think of a better option name since this one is bad for 2183

[mvz]

Maybe :years or :year_numbers could be a good option name?

[jlduran]

Maybe :years or :year_numbers could be a good option name?

Yes, if I understand what this commit is about. Based on (US) English:

• 1,984 should be spelled out by default: one thousand nine hundred eighty-four.
• 1984 plus an option (could be :years) could be spelled out: nineteen eighty-four. I believe this option may have its uses in some sort of text-to-speech application, as not many manuals of style recommend it.
• 1,984 plus an option (could be :keep_spelling_hundreds_instead_of_thousands 🙃) could be spelled out: nineteen hundred eighty-four.

Or poke the CMOS for more inspiration.

If I understand correctly, you are trying to implement the second option?

[mvz]

If I understand correctly, you are trying to implement the second option?

I'm trying to implement the third option for Dutch. Both the second and third options are possible in Dutch.

[dblock]

@mvz want to finish this? or should we merge as is?

[mvz]

@dblock I'll take another look and hopefully finish this in the coming weekend.

[dblock]

@mvz can take a look on green

[mvz]

@dblock it's ready now as far as I'm concerned. I've renamed the option to tens_of_hundreds.

[jlduran]

This just needs an entry in the CHANGELOG, maybe also an addition to the README with the additional option. But that could be committed afterwards. I’ll leave it with @dblock. Thank you @mvz!

[dblock]

@mvz care to please add to the change log/readme so we don’t forget? There’s no rush to merge. Thanks for contributing!

[jlduran]

If there are no objections, I can add the missing CHANGELOG entry this weekend and commit. Thank you!