Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm crd can not generete error #469

Closed

Conversation

tangming1996
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix helm crd can not generete error
Which issue(s) this PR fixes:

Fixes #468

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2025
@tangming1996 tangming1996 force-pushed the bugfix/helm-crd-update branch 2 times, most recently from d6b0f79 to 0fa0b32 Compare February 19, 2025 06:39
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@tangming1996 tangming1996 force-pushed the bugfix/helm-crd-update branch from 0fa0b32 to 7db7458 Compare February 20, 2025 01:59
@tangming1996
Copy link
Collaborator Author

After discussion in the regular meeting, Sedna has no immediate need for multi-version management at present. Therefore, this pull request (PR) will be closed temporarily.

@tangming1996
Copy link
Collaborator Author

/close

@kubeedge-bot
Copy link
Collaborator

@tangming1996: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update of helm crd is fine. But more consideration is needed for the version issue in PR #471 Might launch a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
3 participants