Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code-gen can not surport multi version #471

Closed
wants to merge 1 commit into from

Conversation

tangming1996
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix code-gen can not surport multi version
Which issue(s) this PR fixes:

Fixes #

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@tangming1996
Copy link
Collaborator Author

After discussion in the regular meeting, Sedna has no immediate need for multi-version management at present. Therefore, this pull request (PR) will be closed temporarily.

@tangming1996
Copy link
Collaborator Author

/close

@kubeedge-bot
Copy link
Collaborator

@tangming1996: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is used to automatically generate Sedna API versions. It is useful for compatibility when multiple versions exist.

Nevertheless, multiple API versions could make API selection difficult for newcomers and contributors. For the time being, it would be suggested to create a new branch or even a new scheme for Sedna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants