-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): cover nil status race condition from Tekton #329
Conversation
@adrian555 I just updated the persistent agent image with the this fix, let me know if you still see the nil pointer error. |
/assign @adrian555 |
/assign @drewbutlerbb4 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@drewbutlerbb4 I fixed the conflicts with the upstream code. Does this look good to you? |
Yes, thanks @Tomcli |
…sanitizing-k8s-objects * commit '3d3ecfb05fc13f400d4aec5ee5a0ca9b13b1566f': feat(sdk): added sanitizing k8s object process and test. Fixes: kubeflow#332 (kubeflow#345) add a warning label to kustomize page (kubeflow#350) make user guide prominent (kubeflow#349) feat(backend): ARTIFACT_COPY_STEP_TEMPLATE - custom template for copy step (kubeflow#336) Add KFP Tekton release deployment yaml (kubeflow#347) Fix UI merge conflict that blocks the UI image build. (kubeflow#346) KFP 1.0.4 Rebase (kubeflow#337) fix(sdk): Quick fix for sanitizing conditional variables (kubeflow#344) fix(backend): cover nil status race condition from Tekton (kubeflow#329) updated titanic-ml generated with kale 0.5.1 (kubeflow#330) Add s3 endpoint instructions for admin use case (kubeflow#323) Add best practice for tekton and other argo executors (kubeflow#338)
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Occasionally Tekton may store the pipelineRun to etcd before populating the status field, which it will create a nil pointer panic to the persistent agent. Thus, adding a defer fallback to catch this edge case.
Environment tested:
python --version
):tkn version
): 1.14kubectl version
): 1.16/etc/os-release
):Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234
Use
fix
to indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235
Use
feat
to indicate that this PR adds a new feature.chore: set up changelog generation tools
Use
chore
to indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234
Use
part of
to indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approved
label to this PR. The release manager adds this PR to the release branch in a batch update.