Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): ARTIFACT_COPY_STEP_TEMPLATE - custom template for copy step #336

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

rafalbigaj
Copy link
Contributor

Extend artifacts copy step configuration with the container template.

Which issue is resolved by this Pull Request:
Resolves #333

Description of your changes:
The new ARTIFACT_COPY_STEP_TEMPLATE configuration option is introduced that allow to provide a customisable copy step container template. It is extremely useful in case of custom steps that require access to specific secrets or env variables.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@kubeflow-bot
Copy link

This change is Reviewable

@Tomcli
Copy link
Member

Tomcli commented Oct 16, 2020

Thanks @rafalbigaj, can you add a small section to show what the ARTIFACT_COPY_STEP_TEMPLATE should look like? You can put it under https://github.com/kubeflow/kfp-tekton/blob/master/kfp-admin-guide.md#customize-artifact-image-to-do-your-own-post-processing

@Tomcli
Copy link
Member

Tomcli commented Oct 29, 2020

@rafalbigaj since this feature doesn't break any usability on our side, I can merge it in for now so that we can include it in our 0.4 release. But it will be nice if you can also document how to use it.

@Tomcli
Copy link
Member

Tomcli commented Oct 29, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafalbigaj, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 905079b into kubeflow:master Oct 29, 2020
jizg added a commit to jizg/kfp-tekton that referenced this pull request Nov 3, 2020
…sanitizing-k8s-objects

* commit '3d3ecfb05fc13f400d4aec5ee5a0ca9b13b1566f':
  feat(sdk): added sanitizing k8s object process and test. Fixes: kubeflow#332 (kubeflow#345)
  add a warning label to kustomize page (kubeflow#350)
  make user guide prominent (kubeflow#349)
  feat(backend): ARTIFACT_COPY_STEP_TEMPLATE - custom template for copy step (kubeflow#336)
  Add KFP Tekton release deployment yaml (kubeflow#347)
  Fix UI merge conflict that blocks the UI image build. (kubeflow#346)
  KFP 1.0.4 Rebase (kubeflow#337)
  fix(sdk): Quick fix for sanitizing conditional variables (kubeflow#344)
  fix(backend): cover nil status race condition from Tekton (kubeflow#329)
  updated titanic-ml generated with kale 0.5.1 (kubeflow#330)
  Add s3 endpoint instructions for admin use case (kubeflow#323)
  Add best practice for tekton and other argo executors (kubeflow#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts copy step template
4 participants