Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeflow/pipelines manifests from 2.0.0-alpha.5 #2287

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Update kubeflow/pipelines manifests from 2.0.0-alpha.5 #2287

merged 3 commits into from
Sep 29, 2022

Conversation

annajung
Copy link
Member

Signed-off-by: Anna Jung (VMware) [email protected]

Description of your changes:

cc @kubeflow/release-team @chensun @kimwnasptd

annajung
annajung commented Sep 27, 2022
View reviewed changes
tests/gh-actions/install_pipelines.sh Outdated
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 300s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimwnasptd heads up that I had to increase the time to allow pods to be ready and pass this condition. When testing locally, it took about ~4-5 mins for all pods to come up for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annajung let's actually double that, to have some leeway. Let's do 600s

Copy link
Member Author

@annajung annajung Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - I agree that increasing the timeout a bit more doesn't hurt since when the condition is all met, it completes.

@kimwnasptd
Copy link
Member

kimwnasptd commented Sep 27, 2022 •
edited
Loading

Are we sure the issue is with the timeout and not with the MySQL database not starting, like we saw for katib?

Just saw the above comment #2287 (comment). Thankfully it wasn't that

@kimwnasptd
Copy link
Member

Thanks!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 29, 2022
@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8283ab6 into kubeflow:v1.6-branch Sep 29, 2022
@surajkota surajkota mentioned this pull request Sep 29, 2022
Merged
2 tasks
DomFleischmann pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Nov 21, 2022
Upgrade to 1.6.1
06c3dcd 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).
@DomFleischmann DomFleischmann mentioned this pull request Nov 21, 2022
Merged
ca-scribner pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Nov 28, 2022
@ca-scribner
Upgrade to 1.6.1
f746fd1 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).
DnPlas pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Dec 7, 2022
@DnPlas
Upgrade to 1.6.1
849f3e5 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).
DnPlas pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Dec 7, 2022
@DnPlas
Upgrade to 1.6.1
b7e09fd 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).
ca-scribner pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Dec 8, 2022
@ca-scribner
Upgrade to 1.6.1
6e8e3cf 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).

(cherry picked from commit b7e09fd)
ca-scribner pushed a commit to canonical/kubeflow-roles-operator that referenced this pull request Dec 9, 2022
@ca-scribner
Upgrade to 1.6.1
83f4b99 
Update pipelines roles according to the changes in 2.0.0-alpha.5
Changes can be seen in this upstream PR [#2287](kubeflow/manifests#2287).

(cherry picked from commit b7e09fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@kimwnasptd kimwnasptd

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annajung @kimwnasptd