Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow/pipelines manifests from 2.0.0-alpha.5 #2287

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ This repo periodically syncs all official Kubeflow components from their respect
| Katib | apps/katib/upstream | [v0.14.0-rc.0](https://github.com/kubeflow/katib/tree/v0.14.0-rc.0/manifests/v1beta1) |
| KServe | contrib/kserve/kserve | [release-0.8](https://github.com/kserve/kserve/tree/8079f375cbcedc4d45a1b4aade2e2308ea6f9ae8/install/v0.8.0) |
| KServe Models Web App | contrib/kserve/models-web-app | [v0.8.1](https://github.com/kserve/models-web-app/tree/v0.8.1/config) |
| Kubeflow Pipelines | apps/pipeline/upstream | [2.0.0-alpha.3](https://github.com/kubeflow/pipelines/tree/2.0.0-alpha.3/manifests/kustomize) |
| Kubeflow Pipelines | apps/pipeline/upstream | [2.0.0-alpha.5](https://github.com/kubeflow/pipelines/tree/2.0.0-alpha.5/manifests/kustomize) |
| Kubeflow Tekton Pipelines | apps/kfp-tekton/upstream | [v1.2.1](https://github.com/kubeflow/kfp-tekton/tree/v1.2.1/manifests/kustomize) |

The following is also a matrix with versions from common components that are
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ commonLabels:
app: cache-deployer
images:
- name: gcr.io/ml-pipeline/cache-deployer
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
2 changes: 1 addition & 1 deletion apps/pipeline/upstream/base/cache/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ commonLabels:
app: cache-server
images:
- name: gcr.io/ml-pipeline/cache-server
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
until the changes take effect. A quick way to restart all deployments in a
namespace: `kubectl rollout restart deployment -n <your-namespace>`.
appName: pipeline
appVersion: 2.0.0-alpha.3
appVersion: 2.0.0-alpha.5
dbHost: mysql
dbPort: "3306"
mlmdDb: metadb
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,9 @@ rules:
- get
- list
- watch
- apiGroups:
- ''
resources:
- namespaces
verbs:
- get
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ spec:
spec:
containers:
- name: ml-pipeline-persistenceagent
envFrom:
- configMapRef:
name: persistenceagent-config
env:
- name: NAMESPACE
value: ''
valueFrom: null
- name: KUBEFLOW_USERID_HEADER
value: kubeflow-userid
- name: KUBEFLOW_USERID_PREFIX
value: ""
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ kind: Kustomization
resources:
- cluster-role.yaml
- cluster-role-binding.yaml
configMapGenerator:
- name: persistenceagent-config
envs:
- params.env
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
MULTIUSER=true
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ rules:
- retry
- terminate
- unarchive
- reportMetrics
- readArtifact
- apiGroups:
- pipelines.kubeflow.org
resources:
Expand Down Expand Up @@ -111,11 +113,18 @@ rules:
- pipelines
- pipelines/versions
- experiments
- runs
- jobs
verbs:
- get
- list
- apiGroups:
- pipelines.kubeflow.org
resources:
- runs
verbs:
- get
- list
- readArtifact
- apiGroups:
- kubeflow.org
resources:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ resources:
- metadata-grpc-sa.yaml
images:
- name: gcr.io/ml-pipeline/metadata-envoy
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
12 changes: 6 additions & 6 deletions apps/pipeline/upstream/base/pipeline/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ resources:
- kfp-launcher-configmap.yaml
images:
- name: gcr.io/ml-pipeline/api-server
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
- name: gcr.io/ml-pipeline/persistenceagent
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
- name: gcr.io/ml-pipeline/scheduledworkflow
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
- name: gcr.io/ml-pipeline/frontend
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
- name: gcr.io/ml-pipeline/viewer-crd-controller
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
- name: gcr.io/ml-pipeline/visualization-server
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ resources:
- metadata-writer-sa.yaml
images:
- name: gcr.io/ml-pipeline/metadata-writer
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ spec:
value: "86400"
- name: NUM_WORKERS
value: "2"
- name: KUBEFLOW_USERID_HEADER
value: kubeflow-userid
- name: KUBEFLOW_USERID_PREFIX
value: ""
image: gcr.io/ml-pipeline/persistenceagent:dummy
imagePullPolicy: IfNotPresent
name: ml-pipeline-persistenceagent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,10 @@ rules:
verbs:
- get
- list
- watch
- watch
- apiGroups:
- ''
resources:
- namespaces
verbs:
- get
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: gcr.io/ml-pipeline/inverse-proxy-agent
newTag: 2.0.0-alpha.3
newTag: 2.0.0-alpha.5
resources:
- proxy-configmap.yaml
- proxy-deployment.yaml
Expand Down
2 changes: 1 addition & 1 deletion tests/gh-actions/install_pipelines.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ kubectl apply -f third-party/metacontroller/base/crd.yaml
echo "Waiting for crd/compositecontrollers.metacontroller.k8s.io to be available ..."
kubectl wait --for condition=established --timeout=30s crd/compositecontrollers.metacontroller.k8s.io
kustomize build env/cert-manager/platform-agnostic-multi-user | kubectl apply -f -
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 300s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimwnasptd heads up that I had to increase the time to allow pods to be ready and pass this condition. When testing locally, it took about ~4-5 mins for all pods to come up for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annajung let's actually double that, to have some leeway. Let's do 600s

Copy link
Member Author

@annajung annajung Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - I agree that increasing the timeout a bit more doesn't hurt since when the condition is all met, it completes.