use github container registry instead of gcr.io for releases #1422
Conversation
TomHellier
force-pushed
the
use-github-container-registry-for-ci
branch
7 times, most recently
from
b554c38 to
57e090e
Compare
It appears that it is possible looking at this workflow. https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blame/master/.github/workflows/go.yml It can only be done on the master branch though, so can't find out until after merge Update main.yaml Update main.yaml
TomHellier
force-pushed
the
use-github-container-registry-for-ci
branch
from
57e090e to
816ea95
Compare
Following the guidance from here. This stil might not work, but I don't think there is anthing else that can be done. https://github.blog/changelog/2021-03-24-packages-container-registry-now-supports-github_token/
|
@liyinan926 could you please review? Do you need additional maingainers for this project? |
|
I think this is needed. I tried to deploy the latest release a week ago and the container didn't exist in GCR lol |
|
Yeah I think this repo needs some love might be worth just forking completely 😁 |
|
Thanks for the PR! |
|
Thanks @liyinan926 it appears this new docker release process has worked and there is now a docker container at https://github.com/googlecloudplatform/spark-on-k8s-operator/pkgs/container/spark-operator I'll raise a new pr in the coming days to prefer the docker containers released to ghcr.io which should hopefully stop the issues which are raised constantly on this repo for the helm chart not working. Then hopefully I will make a start on some integration tests, but depends on how much free time I get. |
…w#1422) * use github container registry instead of gcr.io for releases It appears that it is possible looking at this workflow. https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blame/master/.github/workflows/go.yml It can only be done on the master branch though, so can't find out until after merge Update main.yaml Update main.yaml * Update to use github token Following the guidance from here. This stil might not work, but I don't think there is anthing else that can be done. https://github.blog/changelog/2021-03-24-packages-container-registry-now-supports-github_token/
I don't think any CI tool currently deploys the spark-operator to gcr.io, I think @liyinan926 has possibly been doing it manually.
This change moves to using the github container registry because the repository should be able to authenticate with github easier than requiring an administrator of this repository to do some manual steps.
it appears possible looking at this repository
https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blame/master/.github/workflows/go.yml