Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: Announce the Emissary Executor being default starting KFP 1.8 #3108

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

zijianjoy
Copy link
Contributor

Considering the Kubeflow 1.5 release timeline: Feb 24. We will be able to announce this change 30 days ahead of time: kubeflow/community#538.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 7, 2022

/lgtm

@shannonbradshaw
Copy link
Contributor

@zijianjoy do you know why we're seeing errors in the checks above?

@zijianjoy
Copy link
Contributor Author

@shannonbradshaw Issue detail is in #3109, but I don't know the root cause or fix for it yet. We should figure out why this line causes issue: https://github.com/kubeflow/website/blob/master/netlify.toml#L3

@thesuperzapper
Copy link
Member

/retest

@thesuperzapper
Copy link
Member

@shannonbradshaw @zijianjoy I have made PR #3114 which fixes the build issues.

You will need to rebase once that is merged.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 10, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@shannonbradshaw
Copy link
Contributor

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shannonbradshaw, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zijianjoy zijianjoy added the lgtm label Jan 10, 2022
@google-oss-prow google-oss-prow bot merged commit 5fde4a2 into kubeflow:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants