call time middleware support

[davidgamero]

regenerate to support call-time middleware from upstream work in OpenAPITools/openapi-generator#20430

this will enable the use of the middleware property of the options argument to append additional middleware to calls

in particular, we can support something like a WithHeader middleware that allows setting content type for json merge patch or even a wrapper that returns a full options type that can be passed

after unblocking the bugfix, I'll add the WithHeader middleware as an exported function returning a Middleware for ease of use

ex:

// Options type
coreApi.putPod(
  { ... },
  WithHeader('Content-Type','application/json-patch+json'), // would require some chaining/ edits to WithHeader proposed implementation
)

// Middleware array type
coreApi.putPod(
  { ... },
  {
    middleware: WithHeaderMiddleware('Content-Type','application/json-patch+json'),
    middlewareMergeStrategy: 'append'
  }
)

//WithHeaderMiddleware implements Middleware[] Interface
function WithHeaderMiddleware(key: string, value: string): Middleware[]{
	return [{
		pre: (c: RequestContext)=> {
			return new Promise<RequestContext>((resolve)=>{
				c.headers[key] = value
				resolve(c)
			}
		)},
		post: (c: ResponseContext)=> {return new Promise<ResponseContext>((resolve)=>{ resolve(c) })},
	}]
}

// Returns RequestOptions that set a header
func WithHeader(key: string, value: string opt?: RequestOptions): RequestOptions{
  return {
    ...opt,
    middleware: WithHeaderMiddleware(key, value).concat(opt.middleware),
    middlewareMergeStrategy: 'append' // preserve chained middleware from opt
  }
}

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidgamero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidgamero]

waiting on OpenAPITools/openapi-generator#20745 to fix

[brendandburns]

Looks like CI/CD is failing, seems like some error about node 16 or some such, do we need to update our Github action?

[davidgamero]

The ci errors are related to file extensions in the generated files.

I have a PR open upstream to fix it and can re generate once it merges

I'll try updating node on the actions if that fix doesn't resolve it

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: davidgamero / name: David Gamero (e4f1841, 67872ed, 1d6f770, c95b669, 7ad4824, f160c4e, f5f4876, 2530d9e, e04bc14, 697f13b)

[cjihrig]

It looks like there is a problem in the CI, and the bot does not recognize the most recent commit. Also, is it possible to add any unit tests?

[davidgamero]

It looks like there is a problem in the CI, and the bot does not recognize the most recent commit. Also, is it possible to add any unit tests?

yes i think the CI issue is this medyagh/setup-minikube#565

how do we feel about adding something like minikube tests? i was trying to add an integration test that runs the patch example against a minikube cluster

i can add unit tests too, but they'd be mostly just testing the generated codes' features

[cjihrig]

how do we feel about adding something like minikube tests?

Seems like a good idea to me.

[davidgamero]

it appears the CLA doesn't respect force pushes, so i will have to open a new PR redoing this with all signed commits?

[cjihrig]

What if you squash locally and force push this branch?

[davidgamero]

you are right. that worked

[brendandburns]

fwiw, we have KIND based e2e in the Java repo here:

https://github.com/kubernetes-client/java/blob/master/.github/workflows/maven.yml#L66

If you want to add equivalent e2e for this client that would be awesome.

[cjihrig]

Maybe we should move the E2E tests to a separate PR and get this merged.

[davidgamero]

fwiw, we have KIND based e2e in the Java repo here:

https://github.com/kubernetes-client/java/blob/master/.github/workflows/maven.yml#L66

If you want to add equivalent e2e for this client that would be awesome.

i'll use kind then to keep it similar.

Maybe we should move the E2E tests to a separate PR and get this merged.

agreed i'll remove the gh action changes

[davidgamero]

i've added unit tests covering the two header-setting middleware utility functions for now, and will focus on e2e in a separate PR later